From fb55cd1b331abf5a6cc13b8e1fa910747fd925ca Mon Sep 17 00:00:00 2001
From: MaysWind <i@mayswind.net>
Date: Sat, 20 Dec 2025 00:40:58 +0800
Subject: [PATCH] do not switch expression when there are no conditions

---
 src/models/explore.ts                               | 4 ++++
 src/views/desktop/insights/tabs/ExploreQueryTab.vue | 7 ++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/models/explore.ts b/src/models/explore.ts
index 810f4940..9ad73fe4 100644
--- a/src/models/explore.ts
+++ b/src/models/explore.ts
@@ -105,6 +105,10 @@ export class TransactionExploreQuery {
     }
 
     public toExpression(allCategoriesMap: Record<string, TransactionCategory>, allAccountsMap: Record<string, Account>, allTagsMap: Record<string, TransactionTag>): string {
+        if (!this.conditions || this.conditions.length < 1) {
+            return '';
+        }
+
         const postfixExprTokens = this.getPostfixExprTokens();
         const stack: ExpressionNode[] = [];
 
diff --git a/src/views/desktop/insights/tabs/ExploreQueryTab.vue b/src/views/desktop/insights/tabs/ExploreQueryTab.vue
index be3bce0d..708df421 100644
--- a/src/views/desktop/insights/tabs/ExploreQueryTab.vue
+++ b/src/views/desktop/insights/tabs/ExploreQueryTab.vue
@@ -16,6 +16,7 @@
                     <span class="text-subtitle-1">{{ tt('Query') }} {{ `#${queryIndex + 1}` }}</span>
                     <v-spacer />
                     <v-switch class="bidirectional-switch ms-2" color="secondary"
+                              :disabled="!query.conditions || query.conditions.length < 1"
                               :label="tt('Expression')"
                               v-model="showExpression"
                               @click="showExpression = !showExpression">
@@ -40,7 +41,7 @@
                                 {{ tt('No conditions defined. All transactions will match.') }}
                             </div>
 
-                            <div v-if="!showExpression">
+                            <div v-else-if="query.conditions && query.conditions.length > 0 && !showExpression">
                                 <div :key="conditionIndex" v-for="(conditionWithRelation, conditionIndex) in query.conditions">
                                     <div class="d-flex align-center gap-2 mb-4">
                                         <v-select
@@ -268,7 +269,7 @@
                                     </div>
                                 </div>
                             </div>
-                            <div v-else-if="showExpression">
+                            <div v-else-if="query.conditions && query.conditions.length > 0 && showExpression">
                                 <div class="w-100 code-container">
                                     <v-textarea class="w-100 always-cursor-text mb-4" :readonly="true"
                                                 :value="getExpression(queryIndex)"></v-textarea>
@@ -592,7 +593,7 @@ function updateTransactionCategories(changed: boolean, selectedCategoryIds?: str
 function getExpression(queryIndex: number): string {
     const query = queries.value[queryIndex];
 
-    if (!query) {
+    if (!query || !query.conditions || query.conditions.length < 1) {
         return '';
     }