From e15a850cfe097003e73372662dcd66add6edc587 Mon Sep 17 00:00:00 2001
From: MaysWind <i@mayswind.net>
Date: Fri, 26 Jul 2024 00:07:59 +0800
Subject: [PATCH] allow to filter with all tags

---
 .../desktop/common/cards/TransactionTagFilterSettingsCard.vue | 4 +---
 .../mobile/settings/TransactionTagFilterSettingsPage.vue      | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/views/desktop/common/cards/TransactionTagFilterSettingsCard.vue b/src/views/desktop/common/cards/TransactionTagFilterSettingsCard.vue
index 255139ec..d824f051 100644
--- a/src/views/desktop/common/cards/TransactionTagFilterSettingsCard.vue
+++ b/src/views/desktop/common/cards/TransactionTagFilterSettingsCard.vue
@@ -239,7 +239,6 @@ export default {
             const self = this;
 
             const filteredTagIds = {};
-            let isAllSelected = true;
             let finalTagIds = '';
             let changed = true;
 
@@ -252,7 +251,6 @@ export default {
 
                 if (self.filterTagIds[transactionTag.id]) {
                     filteredTagIds[transactionTag.id] = true;
-                    isAllSelected = false;
                 } else {
                     if (finalTagIds.length > 0) {
                         finalTagIds += ',';
@@ -264,7 +262,7 @@ export default {
 
             if (this.type === 'transactionListCurrent') {
                 changed = self.transactionsStore.updateTransactionListFilter({
-                    tagIds: isAllSelected ? '' : finalTagIds
+                    tagIds: finalTagIds
                 });
 
                 if (changed) {
diff --git a/src/views/mobile/settings/TransactionTagFilterSettingsPage.vue b/src/views/mobile/settings/TransactionTagFilterSettingsPage.vue
index 0d845605..236036ac 100644
--- a/src/views/mobile/settings/TransactionTagFilterSettingsPage.vue
+++ b/src/views/mobile/settings/TransactionTagFilterSettingsPage.vue
@@ -214,7 +214,6 @@ export default {
             const router = self.f7router;
 
             const filteredTagIds = {};
-            let isAllSelected = true;
             let finalTagIds = '';
 
             for (let transactionTagId in self.filterTagIds) {
@@ -226,7 +225,6 @@ export default {
 
                 if (self.filterTagIds[transactionTag.id]) {
                     filteredTagIds[transactionTag.id] = true;
-                    isAllSelected = false;
                 } else {
                     if (finalTagIds.length > 0) {
                         finalTagIds += ',';
@@ -238,7 +236,7 @@ export default {
 
             if (this.type === 'transactionListCurrent') {
                 const changed = self.transactionsStore.updateTransactionListFilter({
-                    tagIds: isAllSelected ? '' : finalTagIds
+                    tagIds: finalTagIds
                 });
 
                 if (changed) {