From a235d6a8cde87188b1692af6fba76c8a778f3610 Mon Sep 17 00:00:00 2001 From: MaysWind Date: Tue, 11 Jul 2023 00:35:21 +0800 Subject: [PATCH] code refactor --- src/lib/i18n.js | 11 +++++++++++ src/views/desktop/app/settings/AppBasicSettingTab.vue | 8 +------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/lib/i18n.js b/src/lib/i18n.js index c08c5e49..b5e72a43 100644 --- a/src/lib/i18n.js +++ b/src/lib/i18n.js @@ -627,6 +627,16 @@ function getAllTransactionEditScopeTypes(translateFn) { }]; } +function getEnableDisableOptions(translateFn) { + return [{ + value: true, + displayName: translateFn('Enable') + },{ + value: false, + displayName: translateFn('Disable') + }]; +} + function getDisplayCurrency(value, currencyCode, options, translateFn) { if (!isNumber(value) && !isString(value)) { return value; @@ -896,6 +906,7 @@ export function i18nFunctions(i18nGlobal) { getAllStatisticsChartDataTypes: () => getAllStatisticsChartDataTypes(i18nGlobal.t), getAllStatisticsSortingTypes: () => getAllStatisticsSortingTypes(i18nGlobal.t), getAllTransactionEditScopeTypes: () => getAllTransactionEditScopeTypes(i18nGlobal.t), + getEnableDisableOptions: () => getEnableDisableOptions(i18nGlobal.t), getDisplayCurrency: (value, currencyCode, options) => getDisplayCurrency(value, currencyCode, options, i18nGlobal.t), setLanguage: (locale, force) => setLanguage(i18nGlobal, locale, force), initLocale: (lastUserLanguage, timezone) => initLocale(i18nGlobal, lastUserLanguage, timezone) diff --git a/src/views/desktop/app/settings/AppBasicSettingTab.vue b/src/views/desktop/app/settings/AppBasicSettingTab.vue index 387698ef..7c66ff88 100644 --- a/src/views/desktop/app/settings/AppBasicSettingTab.vue +++ b/src/views/desktop/app/settings/AppBasicSettingTab.vue @@ -176,13 +176,7 @@ export default { computed: { ...mapStores(useRootStore, useSettingsStore, useUserStore, useExchangeRatesStore), enableDisableOptions() { - return [{ - value: true, - displayName: this.$t('Enable') - },{ - value: false, - displayName: this.$t('Disable') - }]; + return this.$locale.getEnableDisableOptions(); }, allTimezones() { return this.$locale.getAllTimezones(true);