code refactor

pkg/api/transaction_templates.go

@@ -15,6 +15,8 @@ import (
 	"github.com/mayswind/ezbookkeeping/pkg/utils"
 )
 
+const maximumTagsCountOfTemplate = 10
+
 // TransactionTemplatesApi represents transaction template api
 type TransactionTemplatesApi struct {
 	ApiUsingConfig
@@ -140,7 +142,7 @@ func (a *TransactionTemplatesApi) TemplateCreateHandler(c *core.WebContext) (any
 		}
 	}
 
-	if len(templateCreateReq.TagIds) > 10 {
+	if len(templateCreateReq.TagIds) > maximumTagsCountOfTemplate {
 		return nil, errs.ErrTransactionTemplateHasTooManyTags
 	}
 
@@ -234,7 +236,7 @@ func (a *TransactionTemplatesApi) TemplateModifyHandler(c *core.WebContext) (any
 		}
 	}
 
-	if len(templateModifyReq.TagIds) > 10 {
+	if len(templateModifyReq.TagIds) > maximumTagsCountOfTemplate {
 		return nil, errs.ErrTransactionTemplateHasTooManyTags
 	}
 

pkg/api/transactions.go

@@ -16,6 +16,9 @@ import (
 	"github.com/mayswind/ezbookkeeping/pkg/utils"
 )
 
+const maximumTagsCountOfTransaction = 10
+const maximumPicturesCountOfTransaction = 10
+
 // TransactionsApi represents transaction api
 type TransactionsApi struct {
 	ApiUsingConfig
@@ -646,8 +649,8 @@ func (a *TransactionsApi) TransactionCreateHandler(c *core.WebContext) (any, *er
 		return nil, errs.ErrTransactionTagIdInvalid
 	}
 
-	if len(tagIds) > 10 {
-		return nil, errs.ErrTransactionTagTooMuch
+	if len(tagIds) > maximumTagsCountOfTransaction {
+		return nil, errs.ErrTransactionHasTooManyTags
 	}
 
 	pictureIds, err := utils.StringArrayToInt64Array(transactionCreateReq.PictureIds)
@@ -657,8 +660,8 @@ func (a *TransactionsApi) TransactionCreateHandler(c *core.WebContext) (any, *er
 		return nil, errs.ErrTransactionPictureIdInvalid
 	}
 
-	if len(pictureIds) > 10 {
-		return nil, errs.ErrTransactionPictureTooMuch
+	if len(pictureIds) > maximumPicturesCountOfTransaction {
+		return nil, errs.ErrTransactionHasTooManyPictures
 	}
 
 	if transactionCreateReq.Type < models.TRANSACTION_TYPE_MODIFY_BALANCE || transactionCreateReq.Type > models.TRANSACTION_TYPE_TRANSFER {
@@ -776,8 +779,8 @@ func (a *TransactionsApi) TransactionModifyHandler(c *core.WebContext) (any, *er
 		return nil, errs.ErrTransactionTagIdInvalid
 	}
 
-	if len(tagIds) > 10 {
-		return nil, errs.ErrTransactionTagTooMuch
+	if len(tagIds) > maximumTagsCountOfTransaction {
+		return nil, errs.ErrTransactionHasTooManyTags
 	}
 
 	pictureIds, err := utils.StringArrayToInt64Array(transactionModifyReq.PictureIds)
@@ -787,8 +790,8 @@ func (a *TransactionsApi) TransactionModifyHandler(c *core.WebContext) (any, *er
 		return nil, errs.ErrTransactionPictureIdInvalid
 	}
 
-	if len(pictureIds) > 10 {
-		return nil, errs.ErrTransactionPictureTooMuch
+	if len(pictureIds) > maximumPicturesCountOfTransaction {
+		return nil, errs.ErrTransactionHasTooManyPictures
 	}
 
 	uid := c.GetCurrentUid()

pkg/errs/transaction.go

@@ -27,4 +27,6 @@ var (
 	ErrCannotUseHiddenAccount                              = NewNormalError(NormalSubcategoryTransaction, 20, http.StatusBadRequest, "cannot use hidden account")
 	ErrCannotUseHiddenTransactionCategory                  = NewNormalError(NormalSubcategoryTransaction, 21, http.StatusBadRequest, "cannot use hidden transaction category")
 	ErrCannotUseHiddenTransactionTag                       = NewNormalError(NormalSubcategoryTransaction, 22, http.StatusBadRequest, "cannot use hidden transaction tag")
+	ErrTransactionHasTooManyTags                           = NewNormalError(NormalSubcategoryTransaction, 23, http.StatusBadRequest, "transaction has too many tags")
+	ErrTransactionHasTooManyPictures                       = NewNormalError(NormalSubcategoryTransaction, 24, http.StatusBadRequest, "transaction has too many pictures")
 )

pkg/errs/transaction_picture.go

@@ -10,5 +10,4 @@ var (
 	ErrTransactionPictureIsEmpty          = NewNormalError(NormalSubcategoryPicture, 3, http.StatusBadRequest, "transaction picture is empty")
 	ErrTransactionPictureNoExists         = NewNormalError(NormalSubcategoryPicture, 4, http.StatusNotFound, "transaction picture not exists")
 	ErrTransactionPictureExtensionInvalid = NewNormalError(NormalSubcategoryPicture, 5, http.StatusNotFound, "transaction picture file extension invalid")
-	ErrTransactionPictureTooMuch          = NewNormalError(NormalSubcategoryPicture, 6, http.StatusBadRequest, "transaction pictures too much")
 )

pkg/errs/transaction_tag.go

@@ -10,5 +10,4 @@ var (
 	ErrTransactionTagNameAlreadyExists    = NewNormalError(NormalSubcategoryTag, 3, http.StatusBadRequest, "transaction tag name already exists")
 	ErrTransactionTagInUseCannotBeDeleted = NewNormalError(NormalSubcategoryTag, 4, http.StatusBadRequest, "transaction tag is in use and cannot be deleted")
 	ErrTransactionTagIndexNotFound        = NewNormalError(NormalSubcategoryTag, 5, http.StatusBadRequest, "transaction tag index not found")
-	ErrTransactionTagTooMuch              = NewNormalError(NormalSubcategoryTag, 6, http.StatusBadRequest, "transaction tags too much")
 )