From 4111eb0838d8658c52c7e9e63a6e15e6e56ac008 Mon Sep 17 00:00:00 2001 From: MaysWind Date: Mon, 9 Jun 2025 23:32:19 +0800 Subject: [PATCH] code refactor --- src/components/base/DateRangeSelectionBase.ts | 4 ++-- .../base/FiscalYearStartSelectionBase.ts | 3 ++- src/components/common/MapView.vue | 4 ++-- src/components/common/PinCodeInput.vue | 6 +++--- .../desktop/DateRangeSelectionDialog.vue | 3 ++- src/components/desktop/DateSelect.vue | 5 +++-- src/components/desktop/DateTimeSelect.vue | 5 +++-- .../desktop/ScheduleFrequencySelect.vue | 5 +++-- src/components/desktop/TwoColumnSelect.vue | 6 +++--- .../mobile/DateRangeSelectionSheet.vue | 4 +++- src/components/mobile/DateSelectionSheet.vue | 3 ++- .../mobile/DateTimeSelectionSheet.vue | 5 +++-- src/components/mobile/InformationSheet.vue | 2 +- .../mobile/ScheduleFrequencySheet.vue | 3 ++- src/core/datetime.ts | 12 +++++++---- src/core/setting.ts | 4 ++-- src/lib/datetime.ts | 21 ++++++++++--------- src/locales/helpers.ts | 5 +++-- src/stores/user.ts | 6 +++--- .../StatisticsTransactionPageBase.ts | 4 ++-- .../transactions/TransactionEditPageBase.ts | 3 ++- .../transactions/TransactionListPageBase.ts | 4 ++-- src/views/desktop/ForgetPasswordPage.vue | 2 +- src/views/desktop/LoginPage.vue | 2 +- src/views/desktop/ResetPasswordPage.vue | 2 +- src/views/desktop/SignupPage.vue | 4 ++-- .../tabs/UserTwoFactorAuthSettingTab.vue | 2 +- 27 files changed, 73 insertions(+), 56 deletions(-) diff --git a/src/components/base/DateRangeSelectionBase.ts b/src/components/base/DateRangeSelectionBase.ts index 9d6c8e9b..d891d12a 100644 --- a/src/components/base/DateRangeSelectionBase.ts +++ b/src/components/base/DateRangeSelectionBase.ts @@ -1,6 +1,6 @@ import { ref, computed } from 'vue'; -import { type TimeRangeAndDateType, type PresetDateRange, type UnixTimeRange, DateRange } from '@/core/datetime.ts'; +import { type TimeRangeAndDateType, type PresetDateRange, type UnixTimeRange, type WeekDayValue, DateRange } from '@/core/datetime.ts'; import { arrangeArrayWithNewStartIndex } from '@/lib/common.ts'; import { getCurrentUnixTime, @@ -60,7 +60,7 @@ export function useDateRangeSelectionBase(props: CommonDateRangeSelectionProps) getLocalDatetimeFromUnixTime(getDummyUnixTimeForLocalUsage(maxDate, getTimezoneOffsetMinutes(), getBrowserTimezoneOffsetMinutes())) ]); - const firstDayOfWeek = computed(() => userStore.currentUserFirstDayOfWeek); + const firstDayOfWeek = computed(() => userStore.currentUserFirstDayOfWeek); const dayNames = computed(() => arrangeArrayWithNewStartIndex(getAllMinWeekdayNames(), firstDayOfWeek.value)); const isYearFirst = computed(() => isLongDateMonthAfterYear()); const is24Hour = computed(() => isLongTime24HourFormat()); diff --git a/src/components/base/FiscalYearStartSelectionBase.ts b/src/components/base/FiscalYearStartSelectionBase.ts index b221fd95..0dfa80ae 100644 --- a/src/components/base/FiscalYearStartSelectionBase.ts +++ b/src/components/base/FiscalYearStartSelectionBase.ts @@ -1,5 +1,6 @@ import { ref, computed } from 'vue'; +import { type WeekDayValue } from '@/core/datetime.ts'; import { FiscalYearStart } from '@/core/fiscalyear.ts'; import { arrangeArrayWithNewStartIndex } from '@/lib/common.ts'; @@ -78,7 +79,7 @@ export function useFiscalYearStartSelectionBase(props: CommonFiscalYearStartSele return formatMonthDayToLongDay(fiscalYearStart.toMonthDashDayString()); }); - const firstDayOfWeek = computed(() => userStore.currentUserFirstDayOfWeek); + const firstDayOfWeek = computed(() => userStore.currentUserFirstDayOfWeek); const dayNames = computed(() => arrangeArrayWithNewStartIndex(getAllMinWeekdayNames(), firstDayOfWeek.value)); return { diff --git a/src/components/common/MapView.vue b/src/components/common/MapView.vue index be356ec6..085038dc 100644 --- a/src/components/common/MapView.vue +++ b/src/components/common/MapView.vue @@ -41,8 +41,8 @@ const zoomLevel = ref(1); const mapSupported = computed(() => !!mapInstance.value); const mapDependencyLoaded = computed(() => mapInstance.value?.dependencyLoaded || false); -const finalMapStyle = computed>(() => { - const styles: Record = Object.assign({}, props.mapStyle); +const finalMapStyle = computed>(() => { + const styles: Record = Object.assign({}, props.mapStyle); if (props.height) { styles['height'] = props.height; diff --git a/src/components/common/PinCodeInput.vue b/src/components/common/PinCodeInput.vue index 823f8048..85c2a50f 100644 --- a/src/components/common/PinCodeInput.vue +++ b/src/components/common/PinCodeInput.vue @@ -2,12 +2,12 @@
+ v-for="(_, index) in codes"> (() => theme.global.name.value === ThemeType.Dark); -const firstDayOfWeek = computed(() => userStore.currentUserFirstDayOfWeek); +const firstDayOfWeek = computed(() => userStore.currentUserFirstDayOfWeek); const showState = computed({ get: () => props.show || false, set: (value) => emit('update:show', value) diff --git a/src/components/desktop/DateSelect.vue b/src/components/desktop/DateSelect.vue index c34b4b82..a2a284c2 100644 --- a/src/components/desktop/DateSelect.vue +++ b/src/components/desktop/DateSelect.vue @@ -5,7 +5,7 @@ :disabled="disabled" :clearable="modelValue ? clearable : false" :label="label" - :menu-props="{ 'content-class': 'date-select-menu' }" + :menu-props="{ contentClass: 'date-select-menu' }" v-model="dateTime" >