From 28322bad5e0551ca9912f854bba3daddd840fbaf Mon Sep 17 00:00:00 2001
From: MaysWind <i@mayswind.net>
Date: Thu, 23 Jan 2025 21:57:53 +0800
Subject: [PATCH] code refactor

---
 src/components/base/PieChartBase.ts           |  96 +++++++++++
 src/components/desktop/PieChart.vue           |  97 +++--------
 src/components/mobile/PieChart.vue            | 162 ++++++------------
 .../mobile/statistics/TransactionPage.vue     |   1 +
 4 files changed, 167 insertions(+), 189 deletions(-)
 create mode 100644 src/components/base/PieChartBase.ts

diff --git a/src/components/base/PieChartBase.ts b/src/components/base/PieChartBase.ts
new file mode 100644
index 00000000..0c779273
--- /dev/null
+++ b/src/components/base/PieChartBase.ts
@@ -0,0 +1,96 @@
+import { ref, computed, watch } from 'vue';
+
+import { useI18n } from '@/locales/helpers.ts';
+
+import { DEFAULT_CHART_COLORS } from '@/consts/color.ts';
+
+import { isNumber } from '@/lib/common.ts';
+import { formatPercent } from '@/lib/numeral.ts';
+
+export interface CommonPieChartDataItem {
+    id: string;
+    name: string;
+    displayName: string;
+    value: number;
+    percent: number;
+    actualPercent: number;
+    color: string;
+    sourceItem: Record<string, unknown>;
+    displayPercent?: string;
+    displayValue?: string;
+}
+
+export interface CommonPieChartProps {
+    skeleton?: boolean;
+    items: Record<string, unknown>[];
+    idField?: string;
+    nameField: string;
+    valueField: string;
+    percentField?: string;
+    colorField?: string;
+    hiddenField?: string;
+    minValidPercent?: number;
+    defaultCurrency?: string;
+    showValue?: boolean;
+    enableClickItem?: boolean;
+}
+
+export function usePieChartBase(props: CommonPieChartProps) {
+    const { formatAmountWithCurrency } = useI18n();
+
+    const selectedIndex = ref<number>(0);
+
+    const validItems = computed<CommonPieChartDataItem[]>(() => {
+        let totalValidValue = 0;
+
+        for (let i = 0; i < props.items.length; i++) {
+            const item = props.items[i];
+            const value = item[props.valueField];
+
+            if (isNumber(value) && value > 0 && (!props.hiddenField || !item[props.hiddenField])) {
+                totalValidValue += value;
+            }
+        }
+
+        const validItems: CommonPieChartDataItem[] = [];
+
+        for (let i = 0; i < props.items.length; i++) {
+            const item = props.items[i];
+            const value = item[props.valueField];
+            const percent = props.percentField ? item[props.percentField] : -1;
+
+            if (isNumber(value) && value > 0 &&
+                (!props.hiddenField || !item[props.hiddenField]) &&
+                (!props.minValidPercent || value / totalValidValue > props.minValidPercent)) {
+                const finalItem: CommonPieChartDataItem = {
+                    id: (props.idField && item[props.idField]) ? item[props.idField] as string : item[props.nameField] as string,
+                    name: (props.idField && item[props.idField]) ? item[props.idField] as string : item[props.nameField] as string,
+                    displayName: item[props.nameField] as string,
+                    value: value,
+                    percent: (isNumber(percent) && percent >= 0) ? percent : (value / totalValidValue * 100),
+                    actualPercent: value / totalValidValue,
+                    color: (props.colorField && item[props.colorField]) ? item[props.colorField] as string : DEFAULT_CHART_COLORS[validItems.length % DEFAULT_CHART_COLORS.length],
+                    sourceItem: item
+                };
+
+                finalItem.displayPercent = formatPercent(finalItem.percent, 2, '&lt;0.01');
+                finalItem.displayValue = formatAmountWithCurrency(finalItem.value, props.defaultCurrency) as string;
+
+                validItems.push(finalItem);
+            }
+        }
+
+        return validItems;
+    });
+
+    watch(() => props.items, () => {
+        selectedIndex.value = 0;
+    });
+
+    return {
+        // states
+        selectedIndex,
+        // computed states
+        validItems
+    };
+}
diff --git a/src/components/desktop/PieChart.vue b/src/components/desktop/PieChart.vue
index 08d5f643..33752399 100644
--- a/src/components/desktop/PieChart.vue
+++ b/src/components/desktop/PieChart.vue
@@ -4,51 +4,29 @@
 </template>
 
 <script setup lang="ts">
-import { ref, computed, watch } from 'vue';
+import { ref, computed } from 'vue';
 import { useTheme } from 'vuetify';
 
 import type { ECElementEvent } from 'echarts/core';
 import type { CallbackDataParams } from 'echarts/types/dist/shared';
 
 import { useI18n } from '@/locales/helpers.ts';
+import { type CommonPieChartDataItem, type CommonPieChartProps, usePieChartBase } from '@/components/base/PieChartBase.ts'
 
 import type { ColorValue } from '@/core/color.ts';
 import { ThemeType } from '@/core/theme.ts';
-import { DEFAULT_ICON_COLOR, DEFAULT_CHART_COLORS } from '@/consts/color.ts';
+import { DEFAULT_ICON_COLOR } from '@/consts/color.ts';
 
-import { isNumber } from '@/lib/common.ts';
-import { formatPercent } from '@/lib/numeral.ts';
-
-interface DesktopPieChartDataItem {
-    id: string;
-    name: string;
-    displayName: string;
-    value: number;
-    percent: number;
-    actualPercent: number;
+interface DesktopPieChartDataItem extends CommonPieChartDataItem {
     itemStyle: {
         color: ColorValue;
     };
     selected: boolean;
-    sourceItem: Record<string, unknown>;
-    displayPercent?: string;
-    displayValue?: string;
 }
 
-const props = defineProps<{
-    skeleton?: boolean;
-    items: Record<string, unknown>[];
-    idField?: string;
-    nameField: string;
-    valueField: string;
-    percentField?: string;
-    colorField?: string;
-    hiddenField?: string;
-    minValidPercent?: number;
-    defaultCurrency?: string;
-    showValue?: boolean;
-    enableClickItem?: boolean;
-}>();
+interface DesktopPieChartProps extends CommonPieChartProps {}
+
+const props = defineProps<DesktopPieChartProps>();
 
 const emit = defineEmits<{
     (e: 'click', value: Record<string, unknown>): void;
@@ -57,9 +35,9 @@ const emit = defineEmits<{
 const theme = useTheme();
 
 const { formatAmountWithCurrency } = useI18n();
+const { selectedIndex, validItems } = usePieChartBase(props);
 
 const selectedLegends = ref<Record<string, boolean> | null>(null);
-const selectedIndex = ref<number>(0);
 
 const isDarkMode = computed<boolean>(() => theme.global.name.value === ThemeType.Dark);
 
@@ -82,50 +60,21 @@ const itemsMap = computed<Record<string, Record<string, unknown>>>(() => {
     return map;
 });
 
-const validItems = computed<DesktopPieChartDataItem[]>(() => {
-    let totalValidValue = 0;
+const seriesData = computed<DesktopPieChartDataItem[]>(() => {
+    const ret: DesktopPieChartDataItem[] = [];
 
-    for (let i = 0; i < props.items.length; i++) {
-        const item = props.items[i];
-        const value = item[props.valueField];
-
-        if (isNumber(value) && value > 0 && (!props.hiddenField || !item[props.hiddenField])) {
-            totalValidValue += value;
-        }
+    for (let i = 0; i < validItems.value.length; i++) {
+        const item = validItems.value[i];
+        ret.push({
+            ...item,
+            itemStyle: {
+                color: getColor(item.color),
+            },
+            selected: true
+        });
     }
 
-    const validItems: DesktopPieChartDataItem[] = [];
-
-    for (let i = 0; i < props.items.length; i++) {
-        const item = props.items[i];
-        const value = item[props.valueField];
-        const percent = props.percentField ? item[props.percentField] : -1;
-
-        if (isNumber(value) && value > 0 &&
-            (!props.hiddenField || !item[props.hiddenField]) &&
-            (!props.minValidPercent || value / totalValidValue > props.minValidPercent)) {
-            const finalItem: DesktopPieChartDataItem = {
-                id: (props.idField && item[props.idField]) ? item[props.idField] as string : item[props.nameField] as string,
-                name: (props.idField && item[props.idField]) ? item[props.idField] as string : item[props.nameField] as string,
-                displayName: item[props.nameField] as string,
-                value: value,
-                percent: (isNumber(percent) && percent >= 0) ? percent : (value / totalValidValue * 100),
-                actualPercent: value / totalValidValue,
-                itemStyle: {
-                    color: getColor((props.colorField && item[props.colorField]) ? item[props.colorField] as ColorValue : DEFAULT_CHART_COLORS[validItems.length % DEFAULT_CHART_COLORS.length]),
-                },
-                selected: true,
-                sourceItem: item
-            };
-
-            finalItem.displayPercent = formatPercent(finalItem.percent, 2, '&lt;0.01');
-            finalItem.displayValue = formatAmountWithCurrency(finalItem.value, props.defaultCurrency) as string;
-
-            validItems.push(finalItem);
-        }
-    }
-
-    return validItems;
+    return ret;
 });
 
 const hasUnselectedItem = computed<boolean>(() => {
@@ -221,7 +170,7 @@ const chartOptions = computed(() => {
         series: [
             {
                 type: 'pie',
-                data: validItems.value,
+                data: seriesData.value,
                 top: 50,
                 startAngle: -90 + firstItemAndHalfCurrentItemTotalPercent.value * 360,
                 emphasis: {
@@ -311,10 +260,6 @@ function onLegendSelectChanged(e: { selected: Record<string, boolean> }): void {
         selectedIndex.value = newSelectedIndex;
     }
 }
-
-watch(() => props.items, () => {
-    selectedIndex.value = 0;
-});
 </script>
 
 <style scoped>
diff --git a/src/components/mobile/PieChart.vue b/src/components/mobile/PieChart.vue
index fed1654b..c5bb2f63 100644
--- a/src/components/mobile/PieChart.vue
+++ b/src/components/mobile/PieChart.vue
@@ -58,7 +58,7 @@
                     </p>
                     <f7-link class="pie-chart-selected-item-info" :no-link-class="!enableClickItem" v-if="selectedItem" @click="clickItem(selectedItem)">
                         <span class="skeleton-text" v-if="skeleton">Name</span>
-                        <span v-else-if="!skeleton && selectedItem.name">{{ selectedItem.name }}</span>
+                        <span v-else-if="!skeleton && selectedItem.displayName">{{ selectedItem.displayName }}</span>
                         <span class="skeleton-text" v-if="skeleton">Value</span>
                         <span v-else-if="!skeleton && showValue" :style="getColorStyle(selectedItem ? selectedItem.color : '')">{{ selectedItem.displayValue }}</span>
                         <f7-icon class="item-navigate-icon" f7="chevron_right" v-if="enableClickItem"></f7-icon>
@@ -77,96 +77,34 @@
 </template>
 
 <script setup lang="ts">
-import { ref, computed, watch } from 'vue';
+import { computed } from 'vue';
 
 import { useI18n } from '@/locales/helpers.ts';
+import { type CommonPieChartDataItem, type CommonPieChartProps, usePieChartBase } from '@/components/base/PieChartBase.ts'
 
 import type { ColorValue } from '@/core/color.ts';
-import { DEFAULT_ICON_COLOR, DEFAULT_CHART_COLORS } from '@/consts/color.ts';
+import { DEFAULT_ICON_COLOR } from '@/consts/color.ts';
 
-import { isNumber } from '@/lib/common.ts';
-import { formatPercent } from '@/lib/numeral.ts';
+interface MobilePieChartDataItem extends CommonPieChartDataItem {}
 
-interface MobilePieChartDataItem {
-    name: string;
-    value: number;
-    percent: number;
-    actualPercent: number;
-    color: ColorValue;
-    sourceItem: Record<string, unknown>;
-    displayPercent?: string;
-    displayValue?: string;
-}
-
-const props = defineProps<{
-    skeleton?: boolean;
-    items: Record<string, unknown>[];
-    nameField: string;
-    valueField: string;
-    percentField?: string;
-    colorField?: string;
-    hiddenField?: string;
-    minValidPercent?: number;
-    defaultCurrency?: string;
-    showValue?: boolean;
+interface MobilePieChartProps extends CommonPieChartProps {
     showCenterText?: boolean;
     showSelectedItemInfo?: boolean;
-    enableClickItem?: boolean;
     centerTextBackground?: ColorValue;
-}>();
+}
+
+const props = defineProps<MobilePieChartProps>();
 
 const emit = defineEmits<{
     (e: 'click', value: Record<string, unknown>): void;
 }>();
 
-const { tt, formatAmountWithCurrency } = useI18n();
+const { tt } = useI18n();
+const { selectedIndex, validItems } = usePieChartBase(props);
 
 const diameter: number = 100;
 const circumference: number = diameter * Math.PI;
 
-const selectedIndex = ref<number>(0);
-
-const validItems = computed<MobilePieChartDataItem[]>(() => {
-    let totalValidValue = 0;
-
-    for (let i = 0; i < props.items.length; i++) {
-        const item = props.items[i];
-        const value = item[props.valueField];
-
-        if (isNumber(value) && value > 0 && (!props.hiddenField || !item[props.hiddenField])) {
-            totalValidValue += value;
-        }
-    }
-
-    const validItems: MobilePieChartDataItem[] = [];
-
-    for (let i = 0; i < props.items.length; i++) {
-        const item = props.items[i];
-        const value = item[props.valueField];
-        const percent = props.percentField ? item[props.percentField] : -1;
-
-        if (isNumber(value) && value > 0 &&
-            (!props.hiddenField || !item[props.hiddenField]) &&
-            (!props.minValidPercent || value / totalValidValue > props.minValidPercent)) {
-            const finalItem: MobilePieChartDataItem = {
-                name: item[props.nameField] as string,
-                value: value,
-                percent: (isNumber(percent) && percent >= 0) ? percent : (value / totalValidValue * 100),
-                actualPercent: value / totalValidValue,
-                color: (props.colorField && item[props.colorField]) ? item[props.colorField] as ColorValue : DEFAULT_CHART_COLORS[validItems.length % DEFAULT_CHART_COLORS.length],
-                sourceItem: item
-            };
-
-            finalItem.displayPercent = formatPercent(finalItem.percent, 2, '&lt;0.01');
-            finalItem.displayValue = formatAmountWithCurrency(finalItem.value, props.defaultCurrency) as string;
-
-            validItems.push(finalItem);
-        }
-    }
-
-    return validItems;
-});
-
 const totalValidValue = computed<number>(() => {
     let totalValidValue = 0;
 
@@ -199,44 +137,6 @@ const itemCommonDashOffset = computed<number>(() => {
     return offset;
 });
 
-const selectedItem = computed<MobilePieChartDataItem | null>(() => {
-    if (!validItems.value || !validItems.value.length) {
-        return null;
-    }
-
-    let index = selectedIndex.value;
-
-    if (index < 0 || index >= validItems.value.length) {
-        index = 0;
-    }
-
-    return validItems.value[index];
-});
-
-watch(() => props.items, () => {
-    selectedIndex.value = 0;
-});
-
-function switchSelectedIndex(index: number): void {
-    selectedIndex.value = index;
-}
-
-function switchSelectedItem(offset: number): void {
-    let newSelectedIndex = selectedIndex.value + offset;
-
-    while (newSelectedIndex < 0) {
-        newSelectedIndex += validItems.value.length;
-    }
-
-    selectedIndex.value = newSelectedIndex % validItems.value.length;
-}
-
-function clickItem(item: MobilePieChartDataItem): void {
-    if (props.enableClickItem) {
-        emit('click', item.sourceItem);
-    }
-}
-
 function getColor(color: ColorValue): ColorValue {
     if (color && color !== DEFAULT_ICON_COLOR) {
         color = '#' + color;
@@ -248,12 +148,14 @@ function getColor(color: ColorValue): ColorValue {
 }
 
 function getColorStyle(color: ColorValue, additionalFieldName?: string): Record<string, string> {
+    const finalColor = getColor(color);
+
     const ret: Record<string, string> = {
-        color: getColor(color)
+        color: finalColor
     };
 
     if (additionalFieldName) {
-        ret[additionalFieldName] = ret.color;
+        ret[additionalFieldName] = finalColor;
     }
 
     return ret;
@@ -290,6 +192,40 @@ function getItemDashOffset(item: MobilePieChartDataItem, items: MobilePieChartDa
     const allPreviousLength = allPreviousPercent * circumference;
     return circumference - allPreviousLength + offset;
 }
+
+const selectedItem = computed<MobilePieChartDataItem | null>(() => {
+    if (!validItems.value || !validItems.value.length) {
+        return null;
+    }
+
+    let index = selectedIndex.value;
+
+    if (index < 0 || index >= validItems.value.length) {
+        index = 0;
+    }
+
+    return validItems.value[index];
+});
+
+function switchSelectedIndex(index: number): void {
+    selectedIndex.value = index;
+}
+
+function switchSelectedItem(offset: number): void {
+    let newSelectedIndex = selectedIndex.value + offset;
+
+    while (newSelectedIndex < 0) {
+        newSelectedIndex += validItems.value.length;
+    }
+
+    selectedIndex.value = newSelectedIndex % validItems.value.length;
+}
+
+function clickItem(item: MobilePieChartDataItem): void {
+    if (props.enableClickItem) {
+        emit('click', item.sourceItem);
+    }
+}
 </script>
 
 <style scoped>
diff --git a/src/views/mobile/statistics/TransactionPage.vue b/src/views/mobile/statistics/TransactionPage.vue
index 63aa6f84..f88a2f0c 100644
--- a/src/views/mobile/statistics/TransactionPage.vue
+++ b/src/views/mobile/statistics/TransactionPage.vue
@@ -60,6 +60,7 @@
                     :show-center-text="true"
                     :show-selected-item-info="true"
                     class="statistics-pie-chart"
+                    name-field="name"
                     value-field="value"
                     color-field="color"
                     center-text-background="#cccccc"