diff --git a/src/components/base/PieChartBase.ts b/src/components/base/PieChartBase.ts index 0c779273..a4da5c3f 100644 --- a/src/components/base/PieChartBase.ts +++ b/src/components/base/PieChartBase.ts @@ -74,7 +74,7 @@ export function usePieChartBase(props: CommonPieChartProps) { }; finalItem.displayPercent = formatPercent(finalItem.percent, 2, '<0.01'); - finalItem.displayValue = formatAmountWithCurrency(finalItem.value, props.defaultCurrency) as string; + finalItem.displayValue = formatAmountWithCurrency(finalItem.value, props.defaultCurrency); validItems.push(finalItem); } diff --git a/src/components/desktop/TrendsChart.vue b/src/components/desktop/TrendsChart.vue index f6247d30..68f00990 100644 --- a/src/components/desktop/TrendsChart.vue +++ b/src/components/desktop/TrendsChart.vue @@ -238,8 +238,8 @@ const yAxisWidth = computed(() => { } } - const maxValueText = formatAmountWithCurrency(maxValue, props.defaultCurrency) || ''; - const minValueText = formatAmountWithCurrency(minValue, props.defaultCurrency) || ''; + const maxValueText = formatAmountWithCurrency(maxValue, props.defaultCurrency); + const minValueText = formatAmountWithCurrency(minValue, props.defaultCurrency); const maxLengthText = maxValueText.length > minValueText.length ? maxValueText : minValueText; const canvas = document.createElement('canvas'); diff --git a/src/lib/currency.ts b/src/lib/currency.ts index 6b808fac..63394d11 100644 --- a/src/lib/currency.ts +++ b/src/lib/currency.ts @@ -1,7 +1,7 @@ import { CurrencyDisplaySymbol, CurrencyDisplayLocation, type CurrencyPrependAndAppendText, CurrencyDisplayType } from '@/core/currency.ts'; import { ALL_CURRENCIES, DEFAULT_CURRENCY_SYMBOL } from '@/consts/currency.ts'; -import { isString, isNumber } from './common.ts'; +import { isNumber } from './common.ts'; export function getCurrencyFraction(currencyCode?: string): number | undefined { if (!currencyCode) { @@ -12,15 +12,11 @@ export function getCurrencyFraction(currencyCode?: string): number | undefined { return currencyInfo?.fraction; } -export function appendCurrencySymbol(value: unknown, currencyDisplayType: CurrencyDisplayType, currencyCode: string, currencyUnit: string, currencyName: string, isPlural: boolean): string | null { +export function appendCurrencySymbol(value: number | string, currencyDisplayType: CurrencyDisplayType, currencyCode: string, currencyUnit: string, currencyName: string, isPlural: boolean): string { if (isNumber(value)) { value = value.toString(); } - if (!isString(value)) { - return null; - } - const symbol = getAmountPrependAndAppendCurrencySymbol(currencyDisplayType, currencyCode, currencyUnit, currencyName, isPlural); if (!symbol) { diff --git a/src/locales/helpers.ts b/src/locales/helpers.ts index ead3b106..6dfd297a 100644 --- a/src/locales/helpers.ts +++ b/src/locales/helpers.ts @@ -1318,11 +1318,7 @@ export function useI18n() { return formatAmount(value, numberFormatOptions); } - function getFormattedAmountWithCurrency(value: number | string, currencyCode?: string | false, notConvertValue?: boolean, currencyDisplayType?: CurrencyDisplayType): string | null { - if (!isNumber(value) && !isString(value)) { - return null; - } - + function getFormattedAmountWithCurrency(value: number | string, currencyCode?: string | false, notConvertValue?: boolean, currencyDisplayType?: CurrencyDisplayType): string { if (isNumber(value)) { value = value.toString(); } @@ -1407,9 +1403,9 @@ export function useI18n() { let accountWithDisplaceBalance: AccountWithDisplayBalance; if (showAccountBalance && account.isAsset) { - accountWithDisplaceBalance = AccountWithDisplayBalance.fromAccount(account, getFormattedAmountWithCurrency(account.balance, account.currency) as string); + accountWithDisplaceBalance = AccountWithDisplayBalance.fromAccount(account, getFormattedAmountWithCurrency(account.balance, account.currency)); } else if (showAccountBalance && account.isLiability) { - accountWithDisplaceBalance = AccountWithDisplayBalance.fromAccount(account, getFormattedAmountWithCurrency(-account.balance, account.currency) as string); + accountWithDisplaceBalance = AccountWithDisplayBalance.fromAccount(account, getFormattedAmountWithCurrency(-account.balance, account.currency)); } else { accountWithDisplaceBalance = AccountWithDisplayBalance.fromAccount(account, '***'); } @@ -1454,7 +1450,7 @@ export function useI18n() { finalTotalBalance = finalTotalBalance + '+'; } - finalTotalBalance = getFormattedAmountWithCurrency(finalTotalBalance, defaultCurrency) as string; + finalTotalBalance = getFormattedAmountWithCurrency(finalTotalBalance, defaultCurrency); } else { finalTotalBalance = '***'; } diff --git a/src/views/base/HomePageBase.ts b/src/views/base/HomePageBase.ts index 2a429238..6b99622d 100644 --- a/src/views/base/HomePageBase.ts +++ b/src/views/base/HomePageBase.ts @@ -38,17 +38,17 @@ export function useHomePageBase() { const netAssets = computed(() => { const netAssets = accountsStore.getNetAssets(showAmountInHomePage.value); - return formatAmountWithCurrency(netAssets, defaultCurrency.value) as string; + return formatAmountWithCurrency(netAssets, defaultCurrency.value); }); const totalAssets = computed(() => { const totalAssets = accountsStore.getTotalAssets(showAmountInHomePage.value); - return formatAmountWithCurrency(totalAssets, defaultCurrency.value) as string; + return formatAmountWithCurrency(totalAssets, defaultCurrency.value); }); const totalLiabilities = computed(() => { const totalLiabilities = accountsStore.getTotalLiabilities(showAmountInHomePage.value); - return formatAmountWithCurrency(totalLiabilities, defaultCurrency.value) as string; + return formatAmountWithCurrency(totalLiabilities, defaultCurrency.value); }); const displayDateRange = computed(() => { @@ -75,7 +75,7 @@ export function useHomePageBase() { function getDisplayAmount(amount: number, incomplete: boolean): string { if (!showAmountInHomePage.value) { - return formatAmountWithCurrency('***', defaultCurrency.value) as string; + return formatAmountWithCurrency('***', defaultCurrency.value); } return formatAmountWithCurrency(amount, defaultCurrency.value) + (incomplete ? '+' : ''); diff --git a/src/views/base/statistics/StatisticsTransactionPageBase.ts b/src/views/base/statistics/StatisticsTransactionPageBase.ts index ad7e6c56..02f91677 100644 --- a/src/views/base/statistics/StatisticsTransactionPageBase.ts +++ b/src/views/base/statistics/StatisticsTransactionPageBase.ts @@ -191,7 +191,7 @@ export function useStatisticsTransactionPageBase() { const trendsAnalysisData = computed(() => statisticsStore.trendsAnalysisData); function getDisplayAmount(amount: number, currency: string, textLimit?: number): string { - const finalAmount = formatAmountWithCurrency(amount, currency) as string; + const finalAmount = formatAmountWithCurrency(amount, currency); if (!showAccountBalance.value && (query.value.chartDataType === ChartDataType.AccountTotalAssets.type diff --git a/src/views/desktop/overview/cards/MonthlyIncomeAndExpenseCard.vue b/src/views/desktop/overview/cards/MonthlyIncomeAndExpenseCard.vue index 8bfb47a5..b31fa426 100644 --- a/src/views/desktop/overview/cards/MonthlyIncomeAndExpenseCard.vue +++ b/src/views/desktop/overview/cards/MonthlyIncomeAndExpenseCard.vue @@ -273,7 +273,7 @@ const chartOptions = computed(() => { }); function getDisplayCurrency(value: number | string, currencyCode: string): string { - return formatAmountWithCurrency(value, currencyCode) || '0'; + return formatAmountWithCurrency(value, currencyCode); } function getDisplayAmount(amount: number, incomplete: boolean): string {