improve performance

pkg/services/transactions.go

@@ -1092,6 +1092,7 @@ func (s *TransactionService) DeleteTransaction(c core.Context, uid int64, transa
 
 		// Update account table
 		if oldTransaction.Type == models.TRANSACTION_DB_TYPE_MODIFY_BALANCE {
+			if oldTransaction.RelatedAccountAmount != 0 {
 				sourceAccount.UpdatedUnixTime = time.Now().Unix()
 				updatedRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance-(%d)", oldTransaction.RelatedAccountAmount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1101,7 +1102,9 @@ func (s *TransactionService) DeleteTransaction(c core.Context, uid int64, transa
 					log.Errorf(c, "[transactions.DeleteTransaction] failed to update account balance")
 					return errs.ErrDatabaseOperationFailed
 				}
+			}
 		} else if oldTransaction.Type == models.TRANSACTION_DB_TYPE_INCOME {
+			if oldTransaction.Amount != 0 {
 				sourceAccount.UpdatedUnixTime = time.Now().Unix()
 				updatedRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance-(%d)", oldTransaction.Amount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1111,7 +1114,9 @@ func (s *TransactionService) DeleteTransaction(c core.Context, uid int64, transa
 					log.Errorf(c, "[transactions.DeleteTransaction] failed to update account balance")
 					return errs.ErrDatabaseOperationFailed
 				}
+			}
 		} else if oldTransaction.Type == models.TRANSACTION_DB_TYPE_EXPENSE {
+			if oldTransaction.Amount != 0 {
 				sourceAccount.UpdatedUnixTime = time.Now().Unix()
 				updatedRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance+(%d)", oldTransaction.Amount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1121,7 +1126,9 @@ func (s *TransactionService) DeleteTransaction(c core.Context, uid int64, transa
 					log.Errorf(c, "[transactions.DeleteTransaction] failed to update account balance")
 					return errs.ErrDatabaseOperationFailed
 				}
+			}
 		} else if oldTransaction.Type == models.TRANSACTION_DB_TYPE_TRANSFER_OUT {
+			if oldTransaction.Amount != 0 {
 				sourceAccount.UpdatedUnixTime = time.Now().Unix()
 				updatedSourceRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance+(%d)", oldTransaction.Amount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1131,16 +1138,19 @@ func (s *TransactionService) DeleteTransaction(c core.Context, uid int64, transa
 					log.Errorf(c, "[transactions.DeleteTransaction] failed to update account balance")
 					return errs.ErrDatabaseOperationFailed
 				}
+			}
 
+			if oldTransaction.RelatedAccountAmount != 0 {
 				destinationAccount.UpdatedUnixTime = time.Now().Unix()
 				updatedDestinationRows, err := sess.ID(destinationAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance-(%d)", oldTransaction.RelatedAccountAmount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", destinationAccount.Uid, false).Update(destinationAccount)
 
 				if err != nil {
 					return err
 				} else if updatedDestinationRows < 1 {
-				log.Errorf(c, "[transactions.DeleteTransaction] failed to update account balance")
+					log.Errorf(c, "[transactions.DeleteTransaction] failed to update related account balance")
 					return errs.ErrDatabaseOperationFailed
 				}
+			}
 		} else if oldTransaction.Type == models.TRANSACTION_DB_TYPE_TRANSFER_IN {
 			return errs.ErrTransactionTypeInvalid
 		}
@@ -1777,6 +1787,7 @@ func (s *TransactionService) doCreateTransaction(c core.Context, database *datas
 
 	// Update account table
 	if transaction.Type == models.TRANSACTION_DB_TYPE_MODIFY_BALANCE {
+		if transaction.RelatedAccountAmount != 0 {
 			sourceAccount.UpdatedUnixTime = time.Now().Unix()
 			updatedRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance+(%d)", transaction.RelatedAccountAmount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1787,7 +1798,9 @@ func (s *TransactionService) doCreateTransaction(c core.Context, database *datas
 				log.Errorf(c, "[transactions.doCreateTransaction] failed to update account balance")
 				return errs.ErrDatabaseOperationFailed
 			}
+		}
 	} else if transaction.Type == models.TRANSACTION_DB_TYPE_INCOME {
+		if transaction.Amount != 0 {
 			sourceAccount.UpdatedUnixTime = time.Now().Unix()
 			updatedRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance+(%d)", transaction.Amount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1798,7 +1811,9 @@ func (s *TransactionService) doCreateTransaction(c core.Context, database *datas
 				log.Errorf(c, "[transactions.doCreateTransaction] failed to update account balance")
 				return errs.ErrDatabaseOperationFailed
 			}
+		}
 	} else if transaction.Type == models.TRANSACTION_DB_TYPE_EXPENSE {
+		if transaction.Amount != 0 {
 			sourceAccount.UpdatedUnixTime = time.Now().Unix()
 			updatedRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance-(%d)", transaction.Amount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1809,7 +1824,9 @@ func (s *TransactionService) doCreateTransaction(c core.Context, database *datas
 				log.Errorf(c, "[transactions.doCreateTransaction] failed to update account balance")
 				return errs.ErrDatabaseOperationFailed
 			}
+		}
 	} else if transaction.Type == models.TRANSACTION_DB_TYPE_TRANSFER_OUT {
+		if transaction.Amount != 0 {
 			sourceAccount.UpdatedUnixTime = time.Now().Unix()
 			updatedSourceRows, err := sess.ID(sourceAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance-(%d)", transaction.Amount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", sourceAccount.Uid, false).Update(sourceAccount)
 
@@ -1820,7 +1837,9 @@ func (s *TransactionService) doCreateTransaction(c core.Context, database *datas
 				log.Errorf(c, "[transactions.doCreateTransaction] failed to update account balance")
 				return errs.ErrDatabaseOperationFailed
 			}
+		}
 
+		if transaction.RelatedAccountAmount != 0 {
 			destinationAccount.UpdatedUnixTime = time.Now().Unix()
 			updatedDestinationRows, err := sess.ID(destinationAccount.AccountId).SetExpr("balance", fmt.Sprintf("balance+(%d)", transaction.RelatedAccountAmount)).Cols("updated_unix_time").Where("uid=? AND deleted=?", destinationAccount.Uid, false).Update(destinationAccount)
 
@@ -1831,6 +1850,7 @@ func (s *TransactionService) doCreateTransaction(c core.Context, database *datas
 				log.Errorf(c, "[transactions.doCreateTransaction] failed to update account balance")
 				return errs.ErrDatabaseOperationFailed
 			}
+		}
 	} else if transaction.Type == models.TRANSACTION_DB_TYPE_TRANSFER_IN {
 		return errs.ErrTransactionTypeInvalid
 	}