mirror/ezbookkeeping
1
0
Fork 0
mirror of https://github.com/mayswind/ezbookkeeping.git synced 2026-05-18 00:34:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

code refactor

Browse Source
This commit is contained in:
MaysWind
2024-11-13 00:46:01 +08:00
parent f5945a788f
commit 7ec1efb85d
1 changed files with 37 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/exchangerates/bank_of_israel_datasource.go
+37 -34
View File
@@ -25,14 +25,14 @@ type BankOfIsraelDataSource struct {
ExchangeRatesDataSource ExchangeRatesDataSource
} }
// bankOfIsraelExchangeRateData represents the whole data from bank of Israel // BankOfIsraelExchangeRateData represents the whole data from bank of Israel
type bankOfIsraelExchangeRateData struct { type BankOfIsraelExchangeRateData struct {
XMLName xml.Name `xml:"ExchangeRatesResponseCollectioDTO"` XMLName xml.Name `xml:"ExchangeRatesResponseCollectioDTO"`
AllExchangeRates []*bankOfIsraelExchangeRate `xml:"ExchangeRates>ExchangeRateResponseDTO"` AllExchangeRates []*BankOfIsraelExchangeRate `xml:"ExchangeRates>ExchangeRateResponseDTO"`
} }
// bankOfIsraelExchangeRate represents the exchange rate data from bank of Israel // BankOfIsraelExchangeRate represents the exchange rate data from bank of Israel
type bankOfIsraelExchangeRate struct { type BankOfIsraelExchangeRate struct {
Currency string `xml:"Key"` Currency string `xml:"Key"`
Rate string `xml:"CurrentExchangeRate"` Rate string `xml:"CurrentExchangeRate"`
LastUpdate string `xml:"LastUpdate"` LastUpdate string `xml:"LastUpdate"`
@@ -40,7 +40,7 @@ type bankOfIsraelExchangeRate struct {
} }
// ToLatestExchangeRateResponse returns a view-object according to original data from bank of Israel // ToLatestExchangeRateResponse returns a view-object according to original data from bank of Israel
func (e *bankOfIsraelExchangeRateData) ToLatestExchangeRateResponse(c core.Context) *models.LatestExchangeRateResponse { func (e *BankOfIsraelExchangeRateData) ToLatestExchangeRateResponse(c core.Context) *models.LatestExchangeRateResponse {
if len(e.AllExchangeRates) < 1 { if len(e.AllExchangeRates) < 1 {
log.Errorf(c, "[bank_of_israel_datasource.ToLatestExchangeRateResponse] all exchange rates is empty") log.Errorf(c, "[bank_of_israel_datasource.ToLatestExchangeRateResponse] all exchange rates is empty")
return nil return nil
@@ -60,35 +60,13 @@ func (e *bankOfIsraelExchangeRateData) ToLatestExchangeRateResponse(c core.Conte
continue continue
} }
rate, err := utils.StringToFloat64(exchangeRate.Rate) finalExchangeRate := exchangeRate.ToLatestExchangeRate(c)
if err != nil { if finalExchangeRate == nil {
log.Warnf(c, "[bank_of_israel_datasource.ToLatestExchangeRateResponse] failed to parse rate, rate is %s", exchangeRate.Rate)
continue continue
} }
if rate <= 0 { exchangeRates = append(exchangeRates, finalExchangeRate)
log.Warnf(c, "[bank_of_israel_datasource.ToLatestExchangeRateResponse] rate is invalid, rate is %s", exchangeRate.Rate)
continue
}
unit, err := utils.StringToFloat64(exchangeRate.Unit)
if err != nil {
log.Warnf(c, "[bank_of_israel_datasource.ToLatestExchangeRateResponse] failed to parse unit, unit is %s", exchangeRate.Unit)
continue
}
finalRate := unit / rate
if math.IsInf(finalRate, 0) {
continue
}
exchangeRates = append(exchangeRates, &models.LatestExchangeRate{
Currency: exchangeRate.Currency,
Rate: utils.Float64ToString(finalRate),
})
} }
updateTime, err := time.Parse(bankOfIsraelDataUpdateDateFormat, latestUpdateDate) updateTime, err := time.Parse(bankOfIsraelDataUpdateDateFormat, latestUpdateDate)
@@ -110,10 +88,35 @@ func (e *bankOfIsraelExchangeRateData) ToLatestExchangeRateResponse(c core.Conte
} }
// ToLatestExchangeRate returns a data pair according to original data from bank of Israel // ToLatestExchangeRate returns a data pair according to original data from bank of Israel
func (e *bankOfIsraelExchangeRate) ToLatestExchangeRate() *models.LatestExchangeRate { func (e *BankOfIsraelExchangeRate) ToLatestExchangeRate(c core.Context) *models.LatestExchangeRate {
rate, err := utils.StringToFloat64(e.Rate)
if err != nil {
log.Warnf(c, "[bank_of_israel_datasource.ToLatestExchangeRate] failed to parse rate, currency is %s, rate is %s", e.Currency, e.Rate)
return nil
}
if rate <= 0 {
log.Warnf(c, "[bank_of_israel_datasource.ToLatestExchangeRate] rate is invalid, currency is %s, rate is %s", e.Currency, e.Rate)
return nil
}
unit, err := utils.StringToFloat64(e.Unit)
if err != nil {
log.Warnf(c, "[bank_of_israel_datasource.ToLatestExchangeRate] failed to parse unit, currency is %s, unit is %s", e.Currency, e.Unit)
return nil
}
finalRate := unit / rate
if math.IsInf(finalRate, 0) {
return nil
}
return &models.LatestExchangeRate{ return &models.LatestExchangeRate{
Currency: e.Currency, Currency: e.Currency,
Rate: e.Rate, Rate: utils.Float64ToString(finalRate),
} }
} }
@@ -124,7 +127,7 @@ func (e *BankOfIsraelDataSource) GetRequestUrls() []string {
// Parse returns the common response entity according to the bank of Israel data source raw response // Parse returns the common response entity according to the bank of Israel data source raw response
func (e *BankOfIsraelDataSource) Parse(c core.Context, content []byte) (*models.LatestExchangeRateResponse, error) { func (e *BankOfIsraelDataSource) Parse(c core.Context, content []byte) (*models.LatestExchangeRateResponse, error) {
bankOfIsraelData := &bankOfIsraelExchangeRateData{} bankOfIsraelData := &BankOfIsraelExchangeRateData{}
err := xml.Unmarshal(content, bankOfIsraelData) err := xml.Unmarshal(content, bankOfIsraelData)
if err != nil { if err != nil {