From 7c67d30222bfd0402e8ed354eb02a007b6570ef1 Mon Sep 17 00:00:00 2001
From: MaysWind <i@mayswind.net>
Date: Mon, 4 May 2026 00:10:40 +0800
Subject: [PATCH] do not attempt to push docker images when the variables of
 docker repository in actions are incomplete

---
 .github/workflows/build-release.yml  | 7 +++++--
 .github/workflows/build-snapshot.yml | 7 +++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml
index 44963ecf..315a74e9 100644
--- a/.github/workflows/build-release.yml
+++ b/.github/workflows/build-release.yml
@@ -9,6 +9,7 @@ jobs:
   setup:
     runs-on: ubuntu-latest
     outputs:
+      docker-push: ${{ steps.variable.outputs.docker_push }}
       build-unix-time: ${{ steps.variable.outputs.build_unix_time }}
       build-date: ${{ steps.variable.outputs.build_date }}
       docker-version: ${{ steps.meta.outputs.version }}
@@ -39,6 +40,7 @@ jobs:
       - name: Set up variables
         id: variable
         run: |
+          echo "docker_push=${{ vars.DOCKER_IMAGE_NAME != '' && vars.DOCKER_USERNAME != '' && secrets.DOCKER_PASSWORD != '' }}" >> "$GITHUB_OUTPUT"
           echo "build_unix_time=$(date '+%s')" >> "$GITHUB_OUTPUT"
           echo "build_date=$(date '+%Y%m%d')" >> "$GITHUB_OUTPUT"
           echo "ezbookkeeping_docker_bake_meta_file_path=${{ runner.temp }}/bake-meta.json" >> "$GITHUB_OUTPUT"
@@ -77,7 +79,7 @@ jobs:
           skip-tests: ${{ vars.SKIP_TESTS }}
           platform: linux/amd64
           platform-name: linux-amd64
-          docker-push: true
+          docker-push: ${{ needs.setup.outputs.docker-push }}
           docker-image-name: ${{ vars.DOCKER_IMAGE_NAME }}
           docker-username: ${{ vars.DOCKER_USERNAME }}
           docker-password: ${{ secrets.DOCKER_PASSWORD }}
@@ -114,7 +116,7 @@ jobs:
           skip-tests: ${{ vars.SKIP_TESTS }}
           platform: ${{ matrix.platform }}
           platform-name: ${{ matrix.platform-name }}
-          docker-push: true
+          docker-push: ${{ needs.setup.outputs.docker-push }}
           docker-image-name: ${{ vars.DOCKER_IMAGE_NAME }}
           docker-username: ${{ vars.DOCKER_USERNAME }}
           docker-password: ${{ secrets.DOCKER_PASSWORD }}
@@ -126,6 +128,7 @@ jobs:
           package-artifact-name-prefix: ${{ needs.setup.outputs.ezbookkeeping-package-artifact-name-prefix }}
 
   push-linux-docker:
+    if: ${{ needs.setup.outputs.docker-push == 'true' }}
     needs:
       - setup
       - build-linux-docker-and-package-x86
diff --git a/.github/workflows/build-snapshot.yml b/.github/workflows/build-snapshot.yml
index c4ffc59b..1dbfe8b4 100644
--- a/.github/workflows/build-snapshot.yml
+++ b/.github/workflows/build-snapshot.yml
@@ -9,6 +9,7 @@ jobs:
   setup:
     runs-on: ubuntu-latest
     outputs:
+      docker-push: ${{ steps.variable.outputs.docker_push }}
       build-unix-time: ${{ steps.variable.outputs.build_unix_time }}
       build-date: ${{ steps.variable.outputs.build_date }}
       docker-version: ${{ steps.meta.outputs.version }}
@@ -39,6 +40,7 @@ jobs:
       - name: Set up variables
         id: variable
         run: |
+          echo "docker_push=${{ vars.DOCKER_IMAGE_NAME != '' && vars.DOCKER_USERNAME != '' && secrets.DOCKER_PASSWORD != '' }}" >> "$GITHUB_OUTPUT"
           echo "build_unix_time=$(date '+%s')" >> "$GITHUB_OUTPUT"
           echo "build_date=$(date '+%Y%m%d')" >> "$GITHUB_OUTPUT"
           echo "ezbookkeeping_docker_bake_meta_file_path=${{ runner.temp }}/bake-meta.json" >> "$GITHUB_OUTPUT"
@@ -76,7 +78,7 @@ jobs:
           skip-tests: ${{ vars.SKIP_TESTS }}
           platform: linux/amd64
           platform-name: linux-amd64
-          docker-push: true
+          docker-push: ${{ needs.setup.outputs.docker-push }}
           docker-image-name: ${{ vars.DOCKER_IMAGE_NAME }}
           docker-username: ${{ vars.DOCKER_USERNAME }}
           docker-password: ${{ secrets.DOCKER_PASSWORD }}
@@ -112,7 +114,7 @@ jobs:
           skip-tests: ${{ vars.SKIP_TESTS }}
           platform: ${{ matrix.platform }}
           platform-name: ${{ matrix.platform-name }}
-          docker-push: true
+          docker-push: ${{ needs.setup.outputs.docker-push }}
           docker-image-name: ${{ vars.DOCKER_IMAGE_NAME }}
           docker-username: ${{ vars.DOCKER_USERNAME }}
           docker-password: ${{ secrets.DOCKER_PASSWORD }}
@@ -124,6 +126,7 @@ jobs:
           package-artifact-name-prefix: ${{ needs.setup.outputs.ezbookkeeping-package-artifact-name-prefix }}
 
   push-linux-docker:
+    if: ${{ needs.setup.outputs.docker-push == 'true' }}
     needs:
       - setup
       - build-linux-docker-and-package-x86