mirror/ezbookkeeping
1
0
Fork 0
mirror of https://github.com/mayswind/ezbookkeeping.git synced 2026-05-18 08:44:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

not allow user add/modify/delete transaction to hidden account

Browse Source
This commit is contained in:
MaysWind
2020-12-09 22:23:35 +08:00
parent 1e2a89a971
commit 65b2028fe9
4 changed files with 33 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/errs/transaction.go
+3
View File
@@ -13,4 +13,7 @@ var (
ErrBalanceModificationTransactionCannotSetCategory = NewNormalError(NORMAL_SUBCATEGORY_TRANSACTION, 7, http.StatusBadRequest, "balance modification transaction cannot set category")
ErrBalanceModificationTransactionCannotChangeAccountId = NewNormalError(NORMAL_SUBCATEGORY_TRANSACTION, 8, http.StatusBadRequest, "balance modification transaction cannot change account id")
ErrBalanceModificationTransactionCannotAddWhenNotEmpty = NewNormalError(NORMAL_SUBCATEGORY_TRANSACTION, 9, http.StatusBadRequest, "balance modification transaction cannot add when other transaction exists")
ErrCannotAddTransactionToHiddenAccount = NewNormalError(NORMAL_SUBCATEGORY_TRANSACTION, 10, http.StatusBadRequest, "cannot add transaction to hidden account")
ErrCannotModifyTransactionInHiddenAccount = NewNormalError(NORMAL_SUBCATEGORY_TRANSACTION, 11, http.StatusBadRequest, "cannot modify transaction of hidden account")
ErrCannotDeleteTransactionInHiddenAccount = NewNormalError(NORMAL_SUBCATEGORY_TRANSACTION, 12, http.StatusBadRequest, "cannot delete transaction in hidden account")
)
pkg/services/transactions.go
+24 -17
View File
@@ -159,6 +159,8 @@ func (s *TransactionService) CreateTransaction(transaction *models.Transaction)
return err
} else if !has {
return errs.ErrSourceAccountNotFound
} else if sourceAccount.Hidden {
return errs.ErrCannotAddTransactionToHiddenAccount
}
if transaction.DestinationAccountId == transaction.SourceAccountId {
@@ -170,6 +172,8 @@ func (s *TransactionService) CreateTransaction(transaction *models.Transaction)
return err
} else if !has {
return errs.ErrDestinationAccountNotFound
} else if destinationAccount.Hidden {
return errs.ErrCannotAddTransactionToHiddenAccount
}
}
@@ -336,28 +340,27 @@ func (s *TransactionService) ModifyTransaction(transaction *models.Transaction)
// Get and verify source and destination account (if necessary)
sourceAccount := &models.Account{}
destinationAccount := &models.Account{}
has, err = sess.ID(transaction.SourceAccountId).Where("uid=? AND deleted=?", transaction.Uid, false).Get(sourceAccount)
if transaction.SourceAccountId != oldTransaction.SourceAccountId || transaction.SourceAmount != oldTransaction.SourceAmount {
has, err := sess.ID(transaction.SourceAccountId).Where("uid=? AND deleted=?", transaction.Uid, false).Get(sourceAccount)
if err != nil {
return err
} else if !has {
return errs.ErrSourceAccountNotFound
} else if sourceAccount.Hidden {
return errs.ErrCannotModifyTransactionInHiddenAccount
}
if transaction.DestinationAccountId == transaction.SourceAccountId {
destinationAccount = sourceAccount
} else {
has, err = sess.ID(transaction.DestinationAccountId).Where("uid=? AND deleted=?", transaction.Uid, false).Get(destinationAccount)
if err != nil {
return err
} else if !has {
return errs.ErrSourceAccountNotFound
}
}
if transaction.DestinationAccountId != oldTransaction.DestinationAccountId || transaction.DestinationAmount != oldTransaction.DestinationAmount {
if transaction.DestinationAccountId == transaction.SourceAccountId {
destinationAccount = sourceAccount
} else {
has, err := sess.ID(transaction.DestinationAccountId).Where("uid=? AND deleted=?", transaction.Uid, false).Get(destinationAccount)
if err != nil {
return err
} else if !has {
return errs.ErrDestinationAccountNotFound
}
return errs.ErrDestinationAccountNotFound
} else if destinationAccount.Hidden {
return errs.ErrCannotModifyTransactionInHiddenAccount
}
}
@@ -545,6 +548,8 @@ func (s *TransactionService) DeleteTransaction(uid int64, transactionId int64) e
return err
} else if !has {
return errs.ErrSourceAccountNotFound
} else if sourceAccount.Hidden {
return errs.ErrCannotDeleteTransactionInHiddenAccount
}
if oldTransaction.DestinationAccountId == oldTransaction.SourceAccountId {
@@ -556,6 +561,8 @@ func (s *TransactionService) DeleteTransaction(uid int64, transactionId int64) e
return err
} else if !has {
return errs.ErrDestinationAccountNotFound
} else if destinationAccount.Hidden {
return errs.ErrCannotDeleteTransactionInHiddenAccount
}
}